Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalar metadata propagation through Array #24

Closed
jrevels opened this issue Dec 22, 2017 · 2 comments
Closed

scalar metadata propagation through Array #24

jrevels opened this issue Dec 22, 2017 · 2 comments

Comments

@jrevels
Copy link
Collaborator

jrevels commented Dec 22, 2017

This is similar to what Box already supports, but allowing for dynamic integer indices in addition to statically named fields.

@jrevels
Copy link
Collaborator Author

jrevels commented Mar 29, 2018

Okay, the hard work for this is done (see e3bbc3e).

The main action items left here are to implement the other array primitives e.g.:

  • Array{T,N}
  • Expr(:foreigncall, :(:jl_array_grow_beg), ...)
  • Expr(:foreigncall, :(:jl_array_grow_end), ...)
  • Expr(:foreigncall, :(:jl_array_grow_at), ...)
  • Expr(:foreigncall, :(:jl_array_del_beg), ...)
  • Expr(:foreigncall, :(:jl_array_del_end), ...)
  • Expr(:foreigncall, :(:jl_array_del_at), ...)

The :foreigncall nodes can just be intercepted as part of Cassette's overdub pass when metadata boxes are enabled (like how Cassette transforms new(...) to _newbox(...)).

@jrevels
Copy link
Collaborator Author

jrevels commented May 10, 2018

superseded by #43

@jrevels jrevels closed this as completed May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant