Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on Julia v1.11 non-allocating internal functions are reported as allocating #60

Closed
nsajko opened this issue Nov 26, 2023 · 3 comments
Closed
Labels
classification error When a function is incorrectly classified as allocating/non-allocating

Comments

@nsajko
Copy link

nsajko commented Nov 26, 2023

On nightly Julia, f_noalias! is reported as allocating:

function f_noalias!(x, y)
  Base.mightalias(x, y) && throw("No aliasing allowed!")
  x .= y
end
using AllocCheck
versioninfo()
check_allocs(f_noalias!, Tuple{Vector{Int}, Vector{Int}})

Initially I reported this to Julia, however vtjnash says that at least one of the two internal functions that AllocCheck blames for the allocations does not allocate:

jl_genericmemory_copyto doesn't allocate, so you should file this on AllocCheck instead

@gbaraldi
Copy link
Member

AllocCheck currently has incomplete information on internal functions and it defaults to marking them as allocating for safety.

@gbaraldi gbaraldi added the classification error When a function is incorrectly classified as allocating/non-allocating label Nov 28, 2023
@topolarity
Copy link
Member

topolarity commented Nov 28, 2023

This was recently fixed in #58

Planning on making a patch release tomorrow which will include this and other fixes.

@gbaraldi
Copy link
Member

Oh ok!, will close then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification error When a function is incorrectly classified as allocating/non-allocating
Projects
None yet
Development

No branches or pull requests

3 participants