Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call to probe_platform_engines! will break in Julia 1.8 #40

Closed
StefanKarpinski opened this issue Jul 2, 2021 · 0 comments
Closed

call to probe_platform_engines! will break in Julia 1.8 #40

StefanKarpinski opened this issue Jul 2, 2021 · 0 comments

Comments

@StefanKarpinski
Copy link
Sponsor Member

JuliaLang/Pkg.jl#2641 deletes the internal probe_platform_engines! which this package calls. This has been a no-op for since Julia 1.6: you can now just download stuff without calling that. As a result:

  • Old versions of this package will break with Julia 1.8, so they will need to be capped in the registry
  • To support both Julia ≤ 1.5 and ≥ 1.6 at the same time, check if the function exists before calling it
  • To support only Julia ≥ 1.6 you can simply delete the call to probe_platform_engines!
@Keno Keno closed this as completed in 0c81794 Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant