Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling in jlkernel execute_request #5

Closed
3 tasks done
stevengj opened this issue Jul 24, 2013 · 3 comments
Closed
3 tasks done

fix handling in jlkernel execute_request #5

stevengj opened this issue Jul 24, 2013 · 3 comments

Comments

@stevengj
Copy link
Member

We have a barely functional execute_request, with many omissions:

  • Currently, we don't really handle exceptions well at all. Related to pyerr messages in Support all message types in jlkernel #4.
  • We don't capture stdout/stderr (see Julia #3823)
  • Results are printed via repr, but we should instead print just like they are printed in the REPL
@stevengj
Copy link
Member Author

Also, we are currently ignoring everything in content except for code. We also need to take into account the other fields:

  • silent - if true, silence stderr, no history, not sure what else
  • store_history
  • user_variables and user_expressions - need to evaluate and return in execute_reply
  • allow_stdin (depends on redirect stdin to frontends #42) - if false, throw exception if read from stdin? or treat stdin as empty file? @fperez?

@fperez, what do we do if evaluating user_variables or user_expressions throws an exception? Also, can we assume that user_expressions are Julia expressions or do we have treat it as Python code?

@stevengj
Copy link
Member Author

Also, we should:

  • suppress output (and history caching) if the code ends with ;, similar to the current Julia REPL.

@stevengj
Copy link
Member Author

Closing this since it is mainly just a matter of implementing #42 at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant