Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing of SyntaxNode -> Expr conversion #120

Closed
c42f opened this issue Oct 7, 2022 · 0 comments · Fixed by #253
Closed

Better testing of SyntaxNode -> Expr conversion #120

c42f opened this issue Oct 7, 2022 · 0 comments · Fixed by #253
Labels
intro issue Good issue to start contributing to JuliaSyntax

Comments

@c42f
Copy link
Member

c42f commented Oct 7, 2022

As exposed by #113, we had some unnecessary regressions due to the Expr conversion code being under-tested.

We need to make sure each branch in src/expr.jl is covered with the tests in test/expr.jl

[update] Some tests are now hosted in test/parser.jl, but it'd be better to move them into test/expr.jl and decouple them from the other tests, I think.

@c42f c42f added the intro issue Good issue to start contributing to JuliaSyntax label Mar 31, 2023
@c42f c42f closed this as completed in #253 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro issue Good issue to start contributing to JuliaSyntax
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant