Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to parse some hex floats #64

Closed
pfitzseb opened this issue Aug 23, 2022 · 0 comments · Fixed by #73
Closed

Failure to parse some hex floats #64

pfitzseb opened this issue Aug 23, 2022 · 0 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@pfitzseb
Copy link
Member

julia> -0x1.428a2f98d728bp+341
-5.643803094122362e102

julia> JuliaSyntax.parse(Expr, "-0x1.428a2f98d728bp+341")
ERROR: ArgumentError: cannot parse "-0x1.428a2e98d728bp+341" as Float32
Stacktrace:
  [1] _parse_failure(T::Type, s::String, startpos::Int64, endpos::Int64) (repeats 2 times)
    @ Base ./parse.jl:373
  [2] #tryparse_internal#477
    @ ./parse.jl:369 [inlined]
  [3] tryparse_internal
    @ ./parse.jl:366 [inlined]
  [4] #parse#478
    @ ./parse.jl:379 [inlined]
  [5] parse
    @ ./parse.jl:379 [inlined]
  [6] julia_string_to_number(str::SubString{String}, kind::JuliaSyntax.Kind)
    @ JuliaSyntax ~/.julia/packages/JuliaSyntax/OawBx/src/value_parsing.jl:26
  [7] JuliaSyntax.SyntaxNode(source::JuliaSyntax.SourceFile, raw::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, position::UInt32)
    @ JuliaSyntax ~/.julia/packages/JuliaSyntax/OawBx/src/syntax_tree.jl:33
  [8] JuliaSyntax.SyntaxNode(source::JuliaSyntax.SourceFile, raw::JuliaSyntax.GreenNode{JuliaSyntax.SyntaxHead}, position::UInt32)
    @ JuliaSyntax ~/.julia/packages/JuliaSyntax/OawBx/src/syntax_tree.jl:89
  [9] build_tree(::Type{JuliaSyntax.SyntaxNode}, stream::JuliaSyntax.ParseStream; filename::Nothing, kws::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ JuliaSyntax ~/.julia/packages/JuliaSyntax/OawBx/src/syntax_tree.jl:189
 [10] build_tree
    @ ~/.julia/packages/JuliaSyntax/OawBx/src/syntax_tree.jl:186 [inlined]
 [11] #build_tree#90
    @ ~/.julia/packages/JuliaSyntax/OawBx/src/expr.jl:208 [inlined]
 [12] build_tree
    @ ~/.julia/packages/JuliaSyntax/OawBx/src/expr.jl:207 [inlined]
 [13] #parse#83
    @ ~/.julia/packages/JuliaSyntax/OawBx/src/parser_api.jl:124 [inlined]
 [14] parse(::Type{Expr}, input::String)
    @ JuliaSyntax ~/.julia/packages/JuliaSyntax/OawBx/src/parser_api.jl:120
 [15] top-level scope
    @ REPL[39]:1

I think we're being to eager in interpreting the f as meaning Float32 here.

@pfitzseb pfitzseb added the bug Something isn't working label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant