Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling julia-config.jl from static_julia.jl #39

Closed
lucatrv opened this issue Feb 21, 2018 · 3 comments
Closed

Avoid calling julia-config.jl from static_julia.jl #39

lucatrv opened this issue Feb 21, 2018 · 3 comments

Comments

@lucatrv
Copy link
Collaborator

lucatrv commented Feb 21, 2018

I think we should avoid calling julia-config.jl with Base.shell_split(read(etc etc)) in static_julia.jl. I have discussed this in the past. Of course we should also avoid code duplication in julia-config.jl and PackageCompiler.jl. We could however for now copy functions cflags, ldflags, ldlibs, allflags into PackageCompiler.jl, if we knew that PackageCompiler.jl is going to be added to Julia stdlib, so that julia-config.jl could be modified to use it at a later stage.
What do you think?
@SimonDanisch
Copy link
Collaborator

Sounds good to me!

@lucatrv
Copy link
Collaborator Author

lucatrv commented Mar 6, 2018

Ok, I am now working on a PR to add new flags and refine default arguments, then I will work on this!

@lucatrv
Copy link
Collaborator Author

lucatrv commented Jul 30, 2018

Implemented with PR #94

@lucatrv lucatrv closed this as completed Jul 30, 2018
@lucatrv lucatrv mentioned this issue Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonDanisch @lucatrv