Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split LinearAlgebra capabilities from other Math capabilities #60

Closed
ViralBShah opened this issue Apr 12, 2023 · 8 comments
Closed

Split LinearAlgebra capabilities from other Math capabilities #60

ViralBShah opened this issue Apr 12, 2023 · 8 comments

Comments

@ViralBShah
Copy link
Contributor

ViralBShah commented Apr 12, 2023

I think it would make sense to separate this into two packages, and move the BLAS/LAPACK into a separate package in JuliaLinearAlgebra called AppleAccelerateLinalg and keep this one as is (but it can depend on AppleAccelerateLinalg`).

Otherwise, people who want the BLAS capabilities also have to opt into all the other things this package provides.

cc @staticfloat

@staticfloat
Copy link
Member

I removed all the other stuff. 😏

@ViralBShah
Copy link
Contributor Author

While extremely unlikely, wouldn't that break people's codes if they were using this package? At the very least, should we move those capabilities to a separate package?

@ViralBShah
Copy link
Contributor Author

@staticfloat I'm happy to attempt creating a new package out of your PR. Is that ok?

@staticfloat
Copy link
Member

Sure

@staticfloat
Copy link
Member

Although it should be noted for the record that there are zero known dependents on this package: https://juliahub.com/ui/Packages/AppleAccelerate/9G3ko/0.3.3?page=2

@ViralBShah
Copy link
Contributor Author

But people probably use it directly, and it would be nice to actually grow those capabilities to cover the rest of Accelerate.

@ViralBShah
Copy link
Contributor Author

Thinking further, a separate package feels like too much work. Can we just reinstate the rest of the Accelerate wrappers here so that we don't lose them, and someone can take that work forward in the future?

@ViralBShah
Copy link
Contributor Author

I've updated #58 to reinstate the earlier functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants