Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible test failure in upcoming Julia version 1.5 #54

Closed
rfourquet opened this issue Apr 24, 2020 · 3 comments
Closed

possible test failure in upcoming Julia version 1.5 #54

rfourquet opened this issue Apr 24, 2020 · 3 comments
Assignees
@Datseris
Labels
bug Something isn't working

Comments

@rfourquet
Copy link

A PkgEval run for a PR which changes the generated numbers for randn! indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.
cf.
https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/MusicManipulations/1.5.0-DEV-71a4a114c2.log
@Datseris Datseris self-assigned this Apr 24, 2020
@Datseris Datseris added the bug Something isn't working label Apr 24, 2020
@Datseris
Copy link
Member

Datseris commented Apr 24, 2020 •
edited
Loading

Thanks a lot for opening this. Could you please link me to the new randn! ? (okay sorry I missed the PR link).

I certainly also have to add a seed! to the tests.

@rfourquet
Copy link
Author

The tests fail also in another PkgEval run for a change in rand(a:b) (JuliaLang/julia#29240).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

@Datseris
Copy link
Member

Datseris commented Jul 5, 2020

I can't reproduce these failings anymore in Julia 1.5.0-rc1. Seems the problem fixed itself :D

@Datseris Datseris closed this as completed Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Datseris Datseris

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfourquet @Datseris