Use browser-launcher2.

[timoxley]

I've kinda just changed this with a quick fix to make it work for me, I'll probably just bundle it into my app if you don't accept this, so whatever. browser-launcher2 resolves the aforementioned browsers not closing on OS X issue.

browser-launcher2 (in yellow) also seems to have far more activity.

[juliangruber]

if this makes it work for you and still works for me, I'm all 👍

But, this doesn't pass the tests locally (either), so i'm investigating

[juliangruber]

this is weird:

not ok test/spawn.js .................................... 2/3
    Command: "/usr/local/bin/node spawn.js"
    TAP version 13
    not ok 1 should be equal
      ---
        file:   /Users/julian/dev/juliangruber/browser-run/test/spawn.js
        line:   8
        column: 7
        stack:
          - getCaller (/Users/julian/dev/juliangruber/browser-run/node_modules/tap/lib/tap-assert.js:418:17)
          - assert (/Users/julian/dev/juliangruber/browser-run/node_modules/tap/lib/tap-assert.js:21:16)
          - Function.equal (/Users/julian/dev/juliangruber/browser-run/node_modules/tap/lib/tap-assert.js:162:10)
          - Test._testAssert [as equal] (/Users/julian/dev/juliangruber/browser-run/node_modules/tap/lib/tap-test.js:87:16)
          - Socket.<anonymous> (/Users/julian/dev/juliangruber/browser-run/test/spawn.js:8:7)
          - Socket.emit (events.js:95:17)
          - Socket.<anonymous> (_stream_readable.js:764:14)
          - Socket.emit (events.js:92:17)
          - emitReadable_ (_stream_readable.js:426:10)
          - emitReadable (_stream_readable.js:422:5)
        found:  console: foo
        wanted: foo
        diff:   |
          FOUND:  console: foo\n
          WANTED: foo\n
                  ^ (at position = 0)

[timoxley]

hm, weird.

[juliangruber]

maybe different phantomjs versions?

[timoxley]

I actually couldn't get phantom to build at the time of this PR, due to yosemite changes. I'll look into this again soon

[zeke]

Hi folks! 👋

I just tried using browser-run on an existing smokestack/tap suite and ran into this issue where the (chrome) browser window doesn't close.

@juliangruber wanna kick off the travis build again and see if it passes? I tried locally but couldn't get tests to pass, even on the master branch: #102

[juliangruber]

@zeke the browser-run part seems to work for me:

 ∴  browser-date-formatter ((HEAD detached at c8558b6)) : ./node_modules/.bin/browserify test/index.js | browser-run
TAP version 13
# formatter
ok 1 uses a relative date string by default
not ok 2 supports custom strftime formats
  ---
    operator: equal
    expected: |-
      '2016-04-07'
    actual: |-
      '2016-04-08'
    at: Test.assert [as _assert] (http://localhost:52352/bundle.js:16353:17)
  ...
 ∴  browser-date-formatter ((HEAD detached at c8558b6)) :

[juliangruber]

@zeke when I change the data assert, it finishes as it should:

 ∴  browser-date-formatter ((HEAD detached at c8558b6)) : ./node_modules/.bin/browserify test/index.js | browser-run
TAP version 13
# formatter
ok 1 uses a relative date string by default
ok 2 supports custom strftime formats
 ∴  browser-date-formatter ((HEAD detached at c8558b6)) :

[fregante]

Closing this as slightly stale