Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting of commands with quoted arguments #309

Closed
snuyanzin opened this issue Jun 6, 2019 · 0 comments · Fixed by #320
Closed

Highlighting of commands with quoted arguments #309

snuyanzin opened this issue Jun 6, 2019 · 0 comments · Fixed by #320

Comments

@snuyanzin
Copy link
Collaborator

Current highlighting of commands with quoted arguments does not work well, for instance

!connect "jdbc:string" admin 'pass "word' driver

everything after !connect will be highlighted as double quoted string.
The same issue is in case of single quoted arguments.
Currently I have it fixed at https://github.com/snuyanzin/sqlline/tree/SQLLLINE_QUOTES_IN_COMMENTS
But I think there should be added some more changes after #305 will be resolved.
@snuyanzin snuyanzin changed the title Highliting of commands with quoted arguments Highlighting of commands with quoted arguments Jun 6, 2019
@snuyanzin snuyanzin mentioned this issue Jul 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SQLLINE-309] Fix highlighting of sqlline commands with quoted arguments snuyanzin/sqlline
1 participant
@snuyanzin