Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot connect, due to recent changes in connect string, user and password handling #352

Closed
julianhyde opened this issue Sep 24, 2019 · 3 comments

Comments

@julianhyde
Copy link
Owner

julianhyde commented Sep 24, 2019

In the vote thread for the 1.9 rc0 release, @arina-ielchiieva reports breakage:

After upgrade, Drill unable to connect to SqlLine, shows the following error:

Usage: connect [-no-np] [-p property value]* [username] [password] [driver]

This is very likely caused by the fix to #326.

@arina-ielchiieva
Copy link
Collaborator

arina-ielchiieva commented Sep 30, 2019

@snuyanzin what do you think should be done to fix the regression so we can proceed with the release?

@snuyanzin
Copy link
Collaborator

It seems I found a solution and added a junittest similar to your case. However it would be nice if you also check your case @arina-ielchiieva

@julianhyde
Copy link
Owner Author

Fixed in ee2d81d. (That commit says that it fixes #326, because we replaced the previous commit that fixed that issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants