Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest not installed following README instructions #46

Closed
nicoguaro opened this issue Jun 22, 2022 · 5 comments · Fixed by #47
Closed

pytest not installed following README instructions #46

nicoguaro opened this issue Jun 22, 2022 · 5 comments · Fixed by #47

Comments

@nicoguaro
Copy link

When you run

python setup.py develop

Pytest is not installed and you can't run the test suite.

@JulianKarlBauer
Copy link
Owner

Hi nicoguaro,
thank you for pointing this out. So far, this is intended behavior.
Why do you expect that installing in "develop"-mode would install pytest?

If I do python setup.py develop on the source code of continuum_mechanics, test requirements are also not met, which from my personal point of view is fine.

If you point me towards an example where installing in develop mode is used to install test requirements, I rethink whether this is to be considered as a feature.

@JulianKarlBauer
Copy link
Owner

Another thought: The tests are run by Github-CI before pushing to PyPI. I don't think any user will run the tests. If so, instructions on running the tests are found in .github/workflow/... files. I think this procedure is quite common.

@nicoguaro
Copy link
Author

I am not thinking as a user in this context but as a contributor. In that case, it is common practice to run tests locally before doing a PR. I would guess that's the public intended for that information.

@JulianKarlBauer
Copy link
Owner

Thank you so much for reminding me on the contributor instructions on tests. Now I realize the problem. I added a note on installing pytest before running the tests. Are you fine with this solution? Please see #47 for a proposal.

@nicoguaro
Copy link
Author

Thank you so much for reminding me on the contributor instructions on tests. Now I realize the problem. I added a note on installing pytest before running the tests. Are you fine with this solution? Please see #47 for a proposal.

It looks OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants