Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jodit Pro OEM #5

Closed
cgraves09 opened this issue Jun 22, 2023 · 13 comments
Closed

Support for Jodit Pro OEM #5

cgraves09 opened this issue Jun 22, 2023 · 13 comments

Comments

@cgraves09
Copy link

Hi does this package support give the ability to pass in our license key for Jodit PRO?

@julianpoemp
Copy link
Owner

in general, ngx-jodit supports all configuration options from Jodit. According to this page there is an option called "license". I don't use Jodit Pro, but it could work like this:

import {Config} from 'jodit/src/config'; // <- this is from Jodit v3
//....
options: Partial<Config> = {
  license: "<LICENSE_KEY>"
};
value: string = "";
//...
<ngx-jodit [(value)]="value" [options]="options"></ngx-jodit>

Unfortunately I can't test it because I don't have any license key. But if it don't work you could tell me how to get it working using vanilla javascript. Then I could translate it to Angular.

@cgraves09
Copy link
Author

@julianpoemp Thank you for getting back to me so quick. So i added that in but it still shows the water mark and doesnt have any of the functionality of the pro.

@julianpoemp
Copy link
Owner

@cgraves09 I found out that there is an extra npm package for jodit-pro here. Because it's a different package from the normal Jodit package with it's own dependencies I'll release a new Angular library with Jodit Pro support. I'll contact you as soon as I have more information.

@cgraves09
Copy link
Author

@julianpoemp Amazing thank you so much

@julianpoemp
Copy link
Owner

@cgraves09 I just released ngx-jodit-pro. You can find more information here:
https://www.npmjs.com/package/ngx-jodit-pro

If you provide a license key in the options it should work now. Please notice: I was able to test it only without a license key and can't say if it works for sure.

Please let me know if it works. In case of errors please send me the console output.

@cgraves09
Copy link
Author

@julianpoemp Awesome thank you. So i am getting
Screenshot 2023-06-26 at 1 15 15 PM
an error from the console

@julianpoemp
Copy link
Owner

@cgraves09 did you follow the installation instructions? Especially adding node_modules/jodit-pro/build/jodit.js to scripts

@cgraves09
Copy link
Author

cgraves09 commented Jun 26, 2023

@julianpoemp Yeah got it. I had the beta Jodit installed. Seems to be rendering now with the license and removing the watermark. Which is fantastic! Not sure if this is an issue but I am getting this type error. Not sure if its going to break anything.
Screenshot 2023-06-26 at 1 27 22 PM

@julianpoemp
Copy link
Owner

@cgraves09 can you send me more of the error message, please? (click on the ">" left to "Uncaught" to expand it")

@cgraves09
Copy link
Author

cgraves09 commented Jun 26, 2023

Screenshot 2023-06-26 at 1 37 03 PM
Here is it expanded let me know if you want all the frames @julianpoemp

@julianpoemp
Copy link
Owner

@cgraves09 I think it's an error caused by Jodit.

I close this issue because the original problem was solved. If you like this package I would be happy if you give this repository a star 😄

@cgraves09
Copy link
Author

@julianpoemp awesome thank you. Idk if you wanted me to open a new issue. I was just curious if we can add in form controls to the component to be injected

@julianpoemp
Copy link
Owner

@cgraves09 form controls? Do you think about buttons for the toolbar or plugins? You can access the jodit instance from ngx-jodit as described here and use the Jodit API to add buttons or plugins (more information here)

This project is just a wrapper for Jodit and I want to keep it light, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants