-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngx-jodit-pro: Angular 16 + vite + esbuild #7
Comments
@vitorlopez I'll release ngx-jodit-pro v3 beta with Angular 16 support soon, perhaps this solves the issue. The angular 16 package comes with an
|
Hey @julianpoemp that would be great. Yea, I'm using other libraries that weren't necessarily built for Angular 16 and they're working like The thing is, this works when I use the regular webpack build, so it has some connection with esbuild for sure. But I'll wait for v3 then to give it another try. Thanks so much for the quick response. |
@vitorlopez I released ngx-jodit-pro v3.0.0-beta.0. You find installation instructions here: Please let me know if it works. I tested it in a v16 angular esbuild project and it worked :) Edit: Do you use SSR? |
@julianpoemp that did fix the issue! 🎉 We're not using SSR yet. Thank you so much, you're fantastic! |
I love the new standalone component, it's so much better not having to import the module anymore! |
I am getting the same error but I am using the ngx-jodit 1.0.8 library. Is this able to be resolved here as well? Thank you. |
@achapman009 I think it's an issue with Angular 13 that was used to build ngx-jodit 1.0.8. Is it an option for you to use the ngx-jodit v3 beta and Jodit v4 beta (that was built with Angular 16 and should resolve this issue) ? |
@julianpoemp This resolved the issue, thank you for the quick response! Appreciate all your work. |
I've tried with the official version and the beta version with the same results.
Angular 16 + esbuild
I know esbuild is probably not stable enough but I've been using it with Angular 16 with no problems since the official release. It is indeed a lot faster than webpack so I believe it's probably going to be adopted by more and more developers pretty soon.
It seems that the ngx-jodit-pro is doing something esbuild is not happy about. I did try to change a few tsconfig rules with no success so far.
It works for the final production build which is interesting and makes me believe there's some issue with Vite instead, but everything start working when I switch back to webpack as the dev server.
I'd really appreciate some help with this issue, Thank you.
The text was updated successfully, but these errors were encountered: