Add django-tos contrib app #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blag thank you for this contribution! I think this could be added but if I understand it correctly it depends on the linked PR being merged into |
|
Sorry I wasn't clear about that - yes, it needs the linked PR to be merged first. That maintainer is pretty active though, so it hopefully shouldn't take too much longer. |
blag
force-pushed
the
contrib-django-tos
branch
2 times, most recently
from
82817e8
to
f16693c
Compare
blag
force-pushed
the
contrib-django-tos
branch
from
f16693c
to
9c139f1
Compare
|
Thanks for your contribution and continued support of this project @blag :) |
|
Thank you for maintaining it for me and the Django community. Happy New Year! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration with django-tos.
It is necessary when using django-tos's middleware option (2). When using django-tos' middleware, since guest users have full user accounts they are required to agree to the site's terms of service before they can do anything else.
I have refactored django-tos a bit in revsys/django-tos#65 specifically to make this custom middleware easier to write. That PR allows us to minimize the amount of code necessary in this middleware and any changes to upstream django-tos should not interfere with this middleware.