Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Common ] FFNx Logo Blackscreen #573

Closed
ChthonVII opened this issue May 29, 2023 · 8 comments
Closed

[ Common ] FFNx Logo Blackscreen #573

ChthonVII opened this issue May 29, 2023 · 8 comments
Labels
bug Something isn't working
Milestone

Comments

@ChthonVII
Copy link
Contributor

It looks like commit 3437968 is buggy. I'm getting a blackscreen for the duration of the FFNx logo.

I stuck in some trace calls, and find that: (1) DrawFFNxLogoFrame() is getting called for every frame 0 through 180. (So why isn't it showing anything?) And, (2) drawFFNxLogoFrame() is also getting called ~100 times for frame 180. (That's probably not right.) I didn't have any luck debugging because it looks like it should be working.

Reverting this commit brought the logo back.

@ChthonVII ChthonVII added the bug Something isn't working label May 29, 2023
@julianxhokaxhiu julianxhokaxhiu added the help wanted Extra attention is needed label May 29, 2023
@julianxhokaxhiu
Copy link
Owner

The only occasion I found out this happens is when DevTools is enabled. Is that happening to you as well? Did you enable the DevTools in the FFNx.toml?

@ChthonVII
Copy link
Contributor Author

Nope, dev tools not enabled. It just failed straight out of the box.

Settings were 4K fullscreen, 6x internal resolution, lighting on, widescreen off, 60fps on.

@julianxhokaxhiu
Copy link
Owner

Thanks, I'll try to test this later here and I'll let you know how it goes with those settings. Can I please ask you to upload also your FFNx.toml used?

@ChthonVII
Copy link
Contributor Author

Afraid that toml file has been overwritten a few times since then. I'd have to recompile the broken version to reproduce.

@julianxhokaxhiu julianxhokaxhiu added feedback Pending for feedback from the user and removed bug Something isn't working labels Jul 9, 2023
@ChthonVII
Copy link
Contributor Author

This issue persists with the new canary.

@ChthonVII
Copy link
Contributor Author

Oh right, now that I've got a binary with this bug again, I can provide FFNx.toml for it. Here's one.

FFNx.toml.zip

The bug also manifests with widescreen turned on, ceteris paribus.

@dotaxis
Copy link
Contributor

dotaxis commented Oct 8, 2023

This seems to be directly affected by the enable_lighting toggle.

FFNx logo disappears when advanced lighting is enabled and shows when it is disabled.

@julianxhokaxhiu
Copy link
Owner

Root cause was not related to Widescreen but as @dotaxis pointed out was related to Lighting. Pushed a fix. Thanks all!

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working and removed help wanted Extra attention is needed feedback Pending for feedback from the user labels Oct 8, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants