Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Common ] FMVs black levels are wrong when HDR is on #499

Closed
N8endo opened this issue Sep 18, 2022 · 17 comments
Closed

[ Common ] FMVs black levels are wrong when HDR is on #499

N8endo opened this issue Sep 18, 2022 · 17 comments
Assignees
Labels
question Further information is requested

Comments

@N8endo
Copy link

N8endo commented Sep 18, 2022

When HDR is enabled in Windows, FMVs and static backgrounds like the background of the promise on the well scene display incorrect black levels. There are crushed blacks and a lot of posterization. When HDR is disabled the game seems to display everything fine.

  • Nvidia RTX 3080
  • Driver Version 516.94

SDR
SDR1

HDR
HDR1

SDR
SDR2

HDR
HDR2

SDR
SDR3

HDR
HDR3

@N8endo N8endo added the bug Something isn't working label Sep 18, 2022
@julianxhokaxhiu
Copy link
Owner

Please provide some screenshots.

@julianxhokaxhiu julianxhokaxhiu added question Further information is requested and removed bug Something isn't working labels Sep 18, 2022
@N8endo
Copy link
Author

N8endo commented Sep 19, 2022

Please provide some screenshots.

Screenshots provided. Notice the really bad posterization in the HDR screenshots compared to the smooth gradients in the SDR pictures.

@julianxhokaxhiu
Copy link
Owner

Did you try the latest FFNx canary before posting the screenshots?

@N8endo
Copy link
Author

N8endo commented Sep 19, 2022

I was on 1.13.0.82

@julianxhokaxhiu
Copy link
Owner

Allright thanks

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working help wanted Extra attention is needed and removed question Further information is requested labels Sep 19, 2022
@julianxhokaxhiu
Copy link
Owner

julianxhokaxhiu commented Sep 20, 2022

I was testing it here and it looks right, not as your screenshots. Have you got more than one HDR monitor attached? And is the game window running on that monitor?

Also, can you please attach the FFNx.log file?

@julianxhokaxhiu julianxhokaxhiu self-assigned this Sep 20, 2022
@julianxhokaxhiu julianxhokaxhiu added question Further information is requested and removed help wanted Extra attention is needed labels Sep 20, 2022
@N8endo
Copy link
Author

N8endo commented Sep 20, 2022

I just have one display - an LG CX tv. I'm on Windows 11, if that makes any difference. The screenshots seem to be slightly exaggerated. It doesn't look exactly that way in-game, but the posterization is definitely still there.

@julianxhokaxhiu julianxhokaxhiu changed the title [ FF7 ] FMVs black levels are wrong when HDR is on [ Common ] FMVs black levels are wrong when HDR is on Feb 5, 2023
@julianxhokaxhiu julianxhokaxhiu added help wanted Extra attention is needed and removed question Further information is requested help wanted Extra attention is needed labels Feb 5, 2023
@julianxhokaxhiu
Copy link
Owner

@N8endo may I ask if you can please try on the latest canary and make sure the window is rendering on the correct monitor that has HDR?

Also, are you having more than one monitor that supports HDR? If so, move it to the screen number 1 when running the game. All the info we use to do HDR comes from the first screen that supports HDR.

@julianxhokaxhiu julianxhokaxhiu added question Further information is requested and removed bug Something isn't working labels Mar 21, 2023
@N8endo
Copy link
Author

N8endo commented Mar 25, 2023

@julianxhokaxhiu I just tested again. The same issue seems to be present. The opening FMV looked good without HDR, but HDR had really bad posterization. I don't have multiple monitors. Only an LG CX.

@julianxhokaxhiu
Copy link
Owner

Thanks for the feedback. I'll keep you posted on the progress.

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working and removed question Further information is requested labels Mar 25, 2023
@ChthonVII
Copy link
Contributor

Only an LG CX.

I'll bet that's the root of it. Apparently there's an issue with some LG monitors that they're missing luminance metadata, so dxgi.dll just poops out a dummy value of 799.0. See here. That's way brighter than the value that we ought to be using (the monitor's SDR white level) and also, assuming this review is correct, brighter than the LG CX's maximum output. Please try setting the max nits in FFNx.toml to 192.

@N8endo
Copy link
Author

N8endo commented Mar 28, 2023

Setting max nits to 192 made it look a bit better, but it's still very different from SDR. The posterization is still there, just less bright.

@ChthonVII
Copy link
Contributor

Could you please post a screen shot of what it looks like with 192 max nits? I've been working a lot on FMV issues generally and some of the other problems in your screenshots believe I've fixed (though I can't test my fixes since I lack a HDR monitor).

@julianxhokaxhiu
Copy link
Owner

@N8endo is the issue still valid? Can you please re-test on the latest canary?

@julianxhokaxhiu julianxhokaxhiu added help wanted Extra attention is needed question Further information is requested and removed bug Something isn't working help wanted Extra attention is needed labels Oct 12, 2023
@N8endo
Copy link
Author

N8endo commented Oct 12, 2023

Ok. I don't have the game installed, but I'll try to install and test tomorrow.

@N8endo
Copy link
Author

N8endo commented Oct 13, 2023

@julianxhokaxhiu @ChthonVII
I just tested it and it seems the issue is gone! That's wonderful! Thank you for your hard work on this game!
Loading up the game after all this time really makes me feel like playing the game again. I may try another playthrough soon.

@julianxhokaxhiu
Copy link
Owner

Thanks a lot for the feedback and enjoy your playthrough :) Cheers!

@julianxhokaxhiu julianxhokaxhiu closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants