Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document safe=true and make it the default? #434

Closed
chriselrod opened this issue Sep 28, 2022 · 1 comment
Closed

Document safe=true and make it the default? #434

chriselrod opened this issue Sep 28, 2022 · 1 comment

Comments

@chriselrod
Copy link
Member

It may make sense to make this the default. @MilesCranmer
@MilesCranmer
Copy link
Contributor

MilesCranmer commented Sep 28, 2022 •
edited
Loading

I think so too. The only reason I could see for not making it default is if can_turbo was not fully general (i.e., some things could be inside @turbo but with can_turbo=false). If it is, then it makes sense to have it default.

chriselrod added a commit that referenced this issue Sep 29, 2022
@chriselrod
safe=true and add a docstring, closes #434
c535cd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MilesCranmer @chriselrod