Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag for enforcing positive definiteness or linesearch #100

Closed
abelsiqueira opened this issue Feb 6, 2019 · 7 comments · Fixed by #191
Closed

Flag for enforcing positive definiteness or linesearch #100

abelsiqueira opened this issue Feb 6, 2019 · 7 comments · Fixed by #191

Comments

@abelsiqueira
Copy link
Member

No description provided.

@dpo
Copy link
Member

dpo commented Feb 7, 2019

... in CG, as is done in CR.

@amontoison
Copy link
Member

I don't really understand what you want; a keyword argument linesearch set to true by default?

@dpo
Copy link
Member

dpo commented Apr 2, 2020

This is an old issue but I think we meant to implement the variant of CG that is used in linesearch methods:

  • if pAp ≤ 0 at the first iteration, return r
  • if pAp ≤ 0 later, return the previous p.

@amontoison
Copy link
Member

Do you still want it? All solvers in Krylov.jl return the solution of the system, so it's a little bit different if we return r or p.

@dpo
Copy link
Member

dpo commented Apr 2, 2020

Sorry, we don't return the last p, we return the last x. It's Alg 17.1 in NW's book.

@amontoison
Copy link
Member

I looked for algorithm 17.1 in Numerial Optimization (edition 1 and 2) of Jorge Nocedal and Stephen Wright and I didn't find it. Did you mean something else with NW?

@dpo
Copy link
Member

dpo commented Apr 2, 2020

I meant 7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants