Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type restriction on ICA #19

Closed
vchuravy opened this issue Dec 1, 2015 · 1 comment
Closed

Type restriction on ICA #19

vchuravy opened this issue Dec 1, 2015 · 1 comment

Comments

@vchuravy
Copy link

vchuravy commented Dec 1, 2015

Fitting on ICA is currently defined as fit(::ICA, X::DenseMatrix{Float64}, k::Int64) [1]

But Matrix{Float64} <: DenseMatrix{Float64}, so calling fit on ICA is not possible at all.

[1]

MultivariateStats.jl/src/ica.jl

Line 151 in 04dc53d

function fit(::Type{ICA}, X::DenseMatrix{Float64}, # sample matrix, size (m, n)

@wildart wildart mentioned this issue Oct 17, 2017
Merged
@wildart
Copy link
Collaborator

wildart commented Oct 17, 2017

Not relevant anymore.

@wildart wildart closed this as completed Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wildart @vchuravy