299 refactor encodings and decodings #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/counterfactuals/core_struct.jl
Outdated
| convergence = Convergence.get_convergence_type(convergence, data.y_levels) | ||
| if generator.latent_space && !(typeof(data.input_encoder) <: GenerativeModels.AbstractGenerativeModel) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if generator.latent_space && !(typeof(data.input_encoder) <: GenerativeModels.AbstractGenerativeModel) | |
| if generator.latent_space && | |
| !(typeof(data.input_encoder) <: GenerativeModels.AbstractGenerativeModel) |
src/counterfactuals/core_struct.jl
Outdated
| @info "No pre-trained generative model found. Training default VAE." | ||
| data.input_encoder = DataPreprocessing.fit_transformer(data, GenerativeModels.VAE) | ||
| end | ||
| if generator.dim_reduction && !(typeof(data.input_encoder) <: MultivariateStats.AbstractDimensionalityReduction) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if generator.dim_reduction && !(typeof(data.input_encoder) <: MultivariateStats.AbstractDimensionalityReduction) | |
| if generator.dim_reduction && | |
| !(typeof(data.input_encoder) <: MultivariateStats.AbstractDimensionalityReduction) |
test/models/generative_models.jl
Outdated
Comment on lines
17
to
19
| CounterfactualExplanations.GenerativeModels.retrain!( | ||
| counterfactual_data.generative_model, X, ys | ||
| counterfactual_data.input_encoder, X | ||
| ) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| CounterfactualExplanations.GenerativeModels.retrain!( | |
| counterfactual_data.generative_model, X, ys | |
| counterfactual_data.input_encoder, X | |
| ) | |
| CounterfactualExplanations.GenerativeModels.retrain!(counterfactual_data.input_encoder, X) |
src/counterfactuals/encodings.jl
Outdated
| @@ -18,17 +27,43 @@ end | |||
|
|
|||
| Helper function to encode an array `x` using a data transform `dt::StatsBase.AbstractDataTransform`. | |||
| """ | |||
| function encode_array(dt::StatsBase.AbstractDataTransform, x::AbstractArray) | |||
| return StatsBase.transform(dt, x) | |||
| function encode_array(data::CounterfactualData, dt::StatsBase.AbstractDataTransform, x::AbstractArray) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function encode_array(data::CounterfactualData, dt::StatsBase.AbstractDataTransform, x::AbstractArray) | |
| function encode_array( | |
| data::CounterfactualData, dt::StatsBase.AbstractDataTransform, x::AbstractArray | |
| ) |
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data.input_encoderfield.