-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt_stats_request limited to 100 results #23
Comments
That's weird, I'm able to get full lists for both contributors and stargazers:
Maybe the problem is with unauthenticated requests? Unfortunately I can't test here, unauthenticated requests from my ip address are being blocked by github for some reason... |
Oh, it has been so long since I've looked at this, totally forgot about https://github.com/WestleyArgentum/GitHub.jl/blob/master/src/utils.jl#L53 So |
Sorry for totally narrating the debugging process, realized that you had |
Alas! I refactored this to support paging, only to discover that github doesn't do paging for contributors because it's too expensive an operation: https://stackoverflow.com/questions/18148490/how-can-i-get-more-than-100-results-from-github-api-v3-using-github-api-gem So I guess this is as fixed as I can make it -- if github ever flips the switch and turns on paging for contributors then it should work |
Actually you can get paginated contributors using a different URL:
It doesn't contain the weeks information but I don't think many people use that anyway. (I certainly don't need it for World of Julia.) |
Interesting, I'll try looking into that then |
Please have a look at that pull request and let me know if it works for you |
The stats URI appears to be hard limited to 100 results and therefore it is not possible to retrieve more than 100 contributors, stargazers, etc. Specifying the additional query "?pages=2" does not change the results, as would be expected from the pagination section of the API
The text was updated successfully, but these errors were encountered: