Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos & Understandability (documentation, methods names and variables....) #65

Open
julien-boudry opened this issue Sep 15, 2021 · 4 comments

Comments

@julien-boudry
Copy link
Owner

Review evrything, evrywhere

@LiamM32
Copy link
Collaborator

LiamM32 commented May 13, 2023

I have been successfully using this in Github Codespaces. But I haven't managed to get it working on my own computer.

The documentation doesn't explain how I get the vendor directory.

@julien-boudry
Copy link
Owner Author

julien-boudry commented May 13, 2023

Maybe, feel free to open an issue about that. If a new answer is needed.

Look first at: https://www.condorcet.io/2.AsCommandLineApplication/1.Installation

The easier way for you may be to Phar method. But they are all easy.

And to install Composer if needed, see here : https://getcomposer.org/

Also, GitHub Codespace execution is great, and I will document it more, congratulations.
But Codespace in web tab, can have little difficulties with interactive shell in some cases.

ps: composer installation is already build in codespace container.

@LiamM32
Copy link
Collaborator

LiamM32 commented Jun 4, 2023

I got it working awhile ago. I don't remember how I solved the problem though.

@LiamM32
Copy link
Collaborator

LiamM32 commented Jun 16, 2023

The documentation about using the new Condorcet Election Format isn't very good. I think it makes sense that you decided to have only one file for both candidates and votes instead of two. But the page doesn't say what namespace the CondorcetElectionFormat class is in. It's also rather inflexible, as it doesn't provide instructions to use the file format to add candidates and votes to an election object that already started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants