Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about remove information about self.column_schemas? #473

Closed
sean-k1 opened this issue Sep 11, 2023 · 0 comments · Fixed by #477
Closed

How about remove information about self.column_schemas? #473

sean-k1 opened this issue Sep 11, 2023 · 0 comments · Fixed by #477

Comments

@sean-k1
Copy link
Collaborator

sean-k1 commented Sep 11, 2023

What do you think about removing the information about self.column_schemas?

Currently we are getting the value of Column schema from information_schema and using it for Column object information (def __parse_column_definition(self, column_type, column_schema, packet)
스크린샷 2023-09-11 오후 2 13 11
I think the Column object should only apply values from Binlog packet values.

Currently, there is information that we get based on the values of column_schema (e.g. unsigned,zerofill, column_comment), but I think it would be better to not use these values and keep only the Column object information by extracting it from the binlog packet and optional meta data values.

Similar projects like ours, go-mysql and rust-mysql-common, do not SELECT information_schema, but only refer to column names in optional metadata.

I expect the standard will eventually be based on optional_metadata.
I'm curious about your thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant