Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shay's world textures conflict #5

Closed
julien-lebot opened this issue Oct 11, 2009 · 1 comment
Closed

Shay's world textures conflict #5

julien-lebot opened this issue Oct 11, 2009 · 1 comment

Comments

@julien-lebot
Copy link
Owner

Shay's world textures conflict with our own textures.
Therefore for testing, the displaying of Shay's world has been disabled and it must be restored when this issue is closed.
The proposed solution is to replace all Shay's world texture handling with our texture manager.

If you would like to work on this issue, put a comment with your name, and your proposed solution (if different from the one described in this issue).
This issue will be opened for 1 week before it is closed for resolution.

@julien-lebot
Copy link
Owner Author

Bug fixed by Joshua the 13/08/2009.
It was a bug in Texture.hpp, the target for the texture bind was wrong: it was not converting the engine's texture target to OpenGL's texture target:

void Texture::bind(const int textureUnit)
{
if(!mID)
return;

if(textureUnit > -1)
glActiveTextureARB(GL_TEXTURE0_ARB + textureUnit);

/// was mTextureTarget
glBindTexture(getGLTextureTarget(), mID);

mCurrtUnit = textureUnit;
}

void Texture::unbind()
{
if(mID > 0 )
{
if(mCurrtUnit > -1)
glActiveTextureARB(GL_TEXTURE0_ARB + mCurrtUnit);

/// was mTextureTarget
glDisable(getGLTextureTarget());

}
}

The issue is now closed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant