Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-appIcon presence invokes extra icon #153

Closed
unknown-- opened this issue Dec 4, 2015 · 1 comment
Closed

-appIcon presence invokes extra icon #153

unknown-- opened this issue Dec 4, 2015 · 1 comment

Comments

@unknown--
Copy link

If -appIcon is invoked then Terminal's icon is appended for whatever reason. Would it not be cleaner to just have the specified app's icon? I get that you might want to include Terminal's icon because the notification isn't generated naturally but shouldn't the end-user be able to specify this?

Normal:
'/usr/local/bin/terminal-notifier -title 'Download Complete' -message "$TNAME"'

Redundant Terminal icon:
'/usr/local/bin/terminal-notifier -title 'Download Complete' -message "$TNAME" -appIcon /Applications/Transmission.app/Contents/Resources/Transmission.icns'

Example
@julienXX
Copy link
Owner

julienXX commented Dec 7, 2015

Please see #131

@julienXX julienXX closed this as completed Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienXX @unknown--