Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkit policy pkexec annotation contains ineffective argv2 specification #5

Open
mgerstner opened this issue Jan 10, 2019 · 0 comments

Comments

@mgerstner
Copy link

mgerstner commented Jan 10, 2019

Your repository contains a polkit policy file that defines a polkit annotation for org.freedesktop.policykit.exec.argv2. This annotation is found here.

In the course of doing a security review of polkit policies in SUSE Linux distributions I came across this usage in a couple of packages. It turns out that while specifying argv1, argv2, etc. restrictions feels natural it isn't supported by polkit. It only supports the specification of an argv1 and that's it. It was probably implemented as a special case to support script parameters for interpreters.

The polkit documentation only explicitly mentions argv1 and also the code only explicitly checks for this annotation.

I suggest to remove this annotation to avoid a false sense of security to developers or users/integrators of your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant