fix(template): fix replacement of a multiple occurence of the same va…

…riable (#46)
juliuscc · May 7, 2020 · 73c2238 · 73c2238
1 parent 37e0df5
commit 73c2238
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/template.js b/lib/template.js
@@ -4,7 +4,7 @@ function template(input, variables) {
       return Object.keys(variables).reduce(
         (output, variable) =>
           variables[variable]
-            ? output.replace(`$${variable}`, variables[variable])
+            ? output.split(`$${variable}`).join(variables[variable])
             : output,
         input
       )

diff --git a/test/test_template.js b/test/test_template.js
@@ -38,6 +38,13 @@ describe('test template', () => {
     assert.equal(expected, actual)
   })
 
+  it('should replace multiple identical variables in string', () => {
+    const world = 'underworld'
+    const expected = `hello ${world}, hello ${world}`
+    const actual = template('hello $world, hello $world', { world })
+    assert.equal(expected, actual)
+  })
+
   it('should replace variable in list', () => {
     const expected = 'underworld'
     const actual = template(['$world'], { world: expected })