-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump peer dependency #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just a typo in the peerDependencies range.
package.json
Outdated
@@ -66,7 +66,7 @@ | |||
"semantic-release": "^15.13.3" | |||
}, | |||
"peerDependencies": { | |||
"semantic-release": ">=11.0.0 <16.0.0" | |||
"semantic-release": ">=11.0.0 <17.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably less than 18 here @juliuscc Or <=
. The latest Semantic Release is 17.0.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that is right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you update the beta release as well? @juliuscc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I will do that so you can try before I merge. 2 min
Sorry @juliuscc but will this |
Good catch! Probably not. |
Check
|
Runs good @juliuscc ! Ship it! 😄 One note tho: This PR is marked as "chore", that won't trigger a new release will it? 🤔 |
Another good catch! Will fix. Thanks as usual @BeyondEvil! 🌟 |
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes: #37