Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump peer dependency #38

Merged
merged 3 commits into from
Mar 28, 2020
Merged

chore: bump peer dependency #38

merged 3 commits into from
Mar 28, 2020

Conversation

juliuscc
Copy link
Owner

@juliuscc juliuscc commented Mar 28, 2020

fixes: #37

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just a typo in the peerDependencies range.

package.json Outdated
@@ -66,7 +66,7 @@
"semantic-release": "^15.13.3"
},
"peerDependencies": {
"semantic-release": ">=11.0.0 <16.0.0"
"semantic-release": ">=11.0.0 <17.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably less than 18 here @juliuscc Or <=. The latest Semantic Release is 17.0.4

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that is right!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fixed now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you update the beta release as well? @juliuscc

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I will do that so you can try before I merge. 2 min

@BeyondEvil
Copy link
Contributor

Sorry @juliuscc but will this <=17.0.0 work with 17.0.4? 🙈

@juliuscc
Copy link
Owner Author

Good catch! Probably not.

@juliuscc
Copy link
Owner Author

Check 1.6.1-beta.1 @BeyondEvil

npm i semantic-release-slack-bot@1.6.1-beta.1

@BeyondEvil
Copy link
Contributor

Runs good @juliuscc ! Ship it! 😄

One note tho: This PR is marked as "chore", that won't trigger a new release will it? 🤔

@juliuscc
Copy link
Owner Author

Another good catch! Will fix. Thanks as usual @BeyondEvil! 🌟

@juliuscc juliuscc merged commit 6103a60 into master Mar 28, 2020
@juliuscc juliuscc deleted the chore/bump-peer-dependency branch March 28, 2020 14:57
@juliuscc
Copy link
Owner Author

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semantic-release v17 support
2 participants