-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to have a custom configuration per branches #63
Conversation
I have a question. I saw you used micromatch. Is that the same pattern-strategy that is used by semantic-release (see here)? It should work identically I think, as a subtly different behavior would be a large cause of friction for users. |
Yes it is exactly the same 👍 If you check the link they put on |
987879b
to
27a9326
Compare
I've looked through the PR and it's great! You have great tests and I think the implementation is clear. It's also great that you expanded the example in the readme. If you fix the small spelling/grammatical nitpicks I will merge 👍 |
I've pushed your suggestions, thanks ! |
Co-authored-by: Julius Recep Colliander Celik <julius.cc@hotmail.com>
dbdf25d
to
997c5b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! 👍
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This could allow to have different behaviours according to the branch from which the release is triggered. For example the following example would allow to have changelog only from
lts/*
andmaster
branches in two different channels :