Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slack token missing bearer prefix #84

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix: slack token missing bearer prefix #84

merged 1 commit into from
Jan 12, 2022

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Jan 12, 2022

Authorization failed due to incorrectly formatted header. Documentation reference: https://api.slack.com/web#slack-web-api__basics__post-bodies__json-encoded-bodies

Authorization failed due to incorrectly formatted header
@juliuscc
Copy link
Owner

Hmm, do you know why this hasn't been a problem before? Just so I know that we don't merge something incorrect by mistake.

Are you using some new features like the new token system? Or do the other users include "Bearer " as a prefix in their token?

@SimeonC
Copy link
Contributor Author

SimeonC commented Jan 12, 2022

Probably because I haven't managed to use it since I originally subitted the feature 😅. I succumbed to the "I read the documentation and this all looks correct" temptation and didn't actually test out a proper release run with my previous PR 🤦. The usage is a little bit weird as if you use the octocat sdk (which I have been elsewhere) you don't need to add the bearer token and I assumed it was the same here - until I dug into the docs when it all failed today (crushing my confidence along the way).
Had a lot of other work issues crop up and some blockers from our infrastructure team that I hadn't actually tried out the feature in a release pipeline till today.

@juliuscc
Copy link
Owner

Okay, that makes sense to me. It explains why the webhook users haven't had any issues.

@juliuscc juliuscc merged commit 1d410f7 into juliuscc:master Jan 12, 2022
@juliuscc
Copy link
Owner

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimeonC SimeonC deleted the fix-bearer-token branch January 12, 2022 10:32
@SimeonC
Copy link
Contributor Author

SimeonC commented Jan 12, 2022

Awesome! Thanks for the quick release ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants