Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple virtual hosts per service in nginx-proxy #72

Open
smesterheide opened this issue Jun 30, 2022 · 5 comments
Open

Support for multiple virtual hosts per service in nginx-proxy #72

smesterheide opened this issue Jun 30, 2022 · 5 comments

Comments

@smesterheide
Copy link
Contributor

Currently the VIRTUAL_HOST environment variable is used by Nextcloud containers to derive an identifier for the instance among other things. This puts some limitations on how nginx-proxy can be used with regard to multiple virtual hosts.

I have a use case where I want to add an external reverse proxy on the web while also keeping the local setup intact. You can find a PoC here https://github.com/smesterheide/nextcloud-docker-dev/tree/app/vo-federation.

If there is interest in this I can create a PR where we disentangle the VIRTUAL_HOST environment variable.

@smesterheide
Copy link
Contributor Author

Ping #64

@juliushaertl
Copy link
Owner

With having a separate reverse proxy doesn't that also work without any adjustments of the nginx-proxys virtual host? I currently haven't seen any other use case but having a separate environment variable that can be set for a public alias would be fine with me as well.

@juliushaertl
Copy link
Owner

@smesterheide
Copy link
Contributor Author

With having a separate reverse proxy doesn't that also work without any adjustments of the nginx-proxys virtual host?

I suppose it would work just the same if you have the additional reverse proxy connect to Nextcloud/Apache on port 8000 of the Docker host. Probably it is not a good idea to change the established environment variables for the majority of users if we do not have a clear use case.

@rhansen
Copy link

rhansen commented Jan 24, 2023

Relevant: nginx-proxy/nginx-proxy#2148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants