Add tests for atoms/second_order_cone #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Jan 15, 2024
| if _value(x) === nothing | ||
| error("Value of the variable is yet to be calculated") | ||
| end | ||
| return output(copy(_value(x))) |
There was a problem hiding this comment.
I think a copy is needed here? It'd be weird if modifying the result of evaluate modified the .value of a variable. (Which is what used to happen in the huber example.)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 95.03% 95.22% +0.19%
==========================================
Files 91 91
Lines 5114 5112 -2
==========================================
+ Hits 4860 4868 +8
+ Misses 254 244 -10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #542