Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] clarify in-place can be slower for small models #3269

Merged
merged 1 commit into from Mar 6, 2023
Merged

Conversation

odow
Copy link
Member

@odow odow commented Mar 6, 2023

x-ref: #3267

I think this was actually compilation latency in the reverse direction.

On my first run, I got

elapsed time: 0.6746890544891357 seconds
elapsed time: 0.32920384407043457 seconds

and on my second I got

elapsed time: 0.09308099746704102 seconds
elapsed time: 0.18986296653747559 seconds

I'm not sure if it's because we've changed things in HiGHS and JuMP since I wrote the tutorial, or if it is to do with recent changes in compilation latency. But I've definitely given tutorials and talks where in-place is faster... (Perhaps it was also back when we used GLPK in the documentation?).

It seems like this could change in the future, so let's be more circumspect in how we word things going forward.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (696fa82) 98.10% compared to head (8952385) 98.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3269   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          34       34           
  Lines        4704     4704           
=======================================
  Hits         4615     4615           
  Misses         89       89           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member Author

odow commented Mar 6, 2023

@jd-foster
Copy link
Collaborator

Looks like the best you can do without adding a big model to the example, but the docs build time is lengthy enough as is.

@odow odow merged commit 3cc78bd into master Mar 6, 2023
@odow odow deleted the odow-patch-2 branch March 6, 2023 06:27
@odow odow mentioned this pull request Mar 6, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants