Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

remove Manifest.toml (add to .gitignore) #41

Closed
chriscoey opened this issue Aug 22, 2019 · 5 comments
Closed

remove Manifest.toml (add to .gitignore) #41

chriscoey opened this issue Aug 22, 2019 · 5 comments

Comments

@chriscoey
Copy link

Other packages (JuMP, MOI, Dualization etc) don't commit Manifest.toml, only Project.toml.
You can see the .gitignore of these packages.

@KristofferC
Copy link

For a set of tutorials I think it is very good to have a Manifest checked in so that you know that the users running the tutorial are running on the same version of the packages as the tutorial was created. This project also has zero [compat] entries so the tutorials here will definitely stop working as soon as any of the dependencies make a breaking change.

@matbesancon
Copy link
Collaborator

@chriscoey I added some compat bounds on Project toml on the "essential" dependencies of the project, so that we can keep manifest and up it without breaking (if all goes well)

@cbdavis
Copy link

cbdavis commented Jun 1, 2020

I'm not able to run the notebooks with IJulia (I get a dead kernel) unless I remove the Manifest.toml file. I've seen this with Julia 1.4.2 on both Windows 10 and Ubuntu 20.04.

@matbesancon
Copy link
Collaborator

the manifest is run with Julia 1.0 normally to ensure compatibility with the LTS

@odow
Copy link
Member

odow commented Feb 22, 2021

Closing as fixed.

@odow odow closed this as completed Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants