Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shipyard destroy with blueprint does not destroy resources #179

Closed
ricochet opened this issue Sep 21, 2022 · 1 comment
Closed

shipyard destroy with blueprint does not destroy resources #179

ricochet opened this issue Sep 21, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ricochet
Copy link

Describe the bug

Shipyard destroy with a directory or git path does not destroy resources.

Use case: development on more than one project, each with their own blueprint or in their current form docker-compose. While iterating one one blueprint, I do not want to destroy the other stack.

To Reproduce
Steps to reproduce the behavior:

  1. shipyard run github.com/shipyard-run/blueprints//vault-k8s
  2. shipyard destroy github.com/shipyard-run/blueprints//vault-k8s
  3. Nothing is printed to the console and no action is taken.
  4. Run another blueprint. Most of the ones in the blueprint repo bind on 0.0.0.0:43 so you'll get errors like "Bind for 0.0.0.0:443 failed: port is already allocated". shipyard run any of these and you'll see that in the next command (even if the allocation fails) you'll see it's attempted to be destroyed.
  5. shipyard destroy - all stacks are destroyed.

Expected behavior

Ability to destroy resources as described by a blueprint. The docs imply this is expected to work: https://shipyard.run/docs/commands/destroy

I expected similar behavior to docker-compose stop -f <file>

Desktop (please complete the following information):
macos m1

@nicholasjackson
Copy link
Contributor

Hey, @ricochet this is a good catch, while you can do something like shipyard run ./folder and shipyard destroy ./folder this does not work the same way for blueprints that are downloaded. The behavior as you correctly state should be the same and can lead to confusing situations.

This is a pretty simple change, I will make sure I add it the next time I do an update, for now, the only workaround is to do the destroy on the folder containing the downloaded blueprint. In your example, this should be something like $HOME/.shipyard/blueprints/github.com/shipyard-run/vault-k8s.

@nicholasjackson nicholasjackson added the bug Something isn't working label Sep 23, 2022
@nicholasjackson nicholasjackson self-assigned this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants