Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Unexpected identifier error #4

Closed
ahmad-reza619 opened this issue Jan 18, 2022 · 8 comments
Closed

Unexpected identifier error #4

ahmad-reza619 opened this issue Jan 18, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@ahmad-reza619
Copy link
Contributor

I got an error at this line, saying it's a SyntaxError, this probably due to my version of node, i'm using node 14.17.6

https://github.com/JumpyJacko/manga-cli/blob/f8c70013f23d87c6f187b6c75a18d5a1644fb53c/src/modules/fetch-manga-by-title.js#L17

What version of node did you use?

@jumpyjacko
Copy link
Owner

I'm using Node v17.3.0.

@jumpyjacko jumpyjacko added the bug Something isn't working label Jan 19, 2022
@ahmad-reza619
Copy link
Contributor Author

If that's the case, i think we should mention that in the readme, to use node >17

@jumpyjacko
Copy link
Owner

Does using node >17 fix the problem?

@ahmad-reza619
Copy link
Contributor Author

Does using node >17 fix the problem?

yes it is, but if you want to support other node version, i suggest to delete the assert.
so the import would look like this

import options from '../options.json';

I'll gladly open PR for this

@jumpyjacko
Copy link
Owner

jumpyjacko commented Jan 19, 2022

I tried using it without, but without it, it didn't let me access the .json without doing a couple of other things. Probably should support the LTS version of node so that's probably a good idea.

@ahmad-reza619
Copy link
Contributor Author

@jumpyjacko have you tried switching node version before tried to import options without assert?

@jumpyjacko
Copy link
Owner

No, I should probably do that, sorry about that. Completely forgot about trying that.

@jumpyjacko
Copy link
Owner

Fixed the issue because I used node 16 and removed assert

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants