Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in chrome 83 #80

Closed
pichuser opened this issue May 21, 2020 · 6 comments
Closed

Not working in chrome 83 #80

pichuser opened this issue May 21, 2020 · 6 comments

Comments

@pichuser
Copy link

pichuser commented May 21, 2020

Today I update my chrome to 83. And now this extension is broken... After write node --inspect --inspect-brk - I get many, very many tabs in chrome... New tab is opening every half second until stop terminal. The same behavior in canary (version 85)

june07 added a commit that referenced this issue May 21, 2020
@june07
Copy link
Owner

june07 commented May 21, 2020

It appears to be an issue of Node still spitting our non agnostic debugging URLS. And the new version of Chrome removing some fallback code. See https://chromium-review.googlesource.com/c/chromium/src/+/1582881

I've actually implemented and pushed a fix to GitHub. I will shortly push to the Chrome Web Store however there's no telling how long it will take for that to go thru.

@june07
Copy link
Owner

june07 commented May 21, 2020

For those so inclined who would rather not wait I've pushed the file here as well:
https://github.com/june07/NiM/releases/tag/v2.4.0

@june07
Copy link
Owner

june07 commented May 21, 2020

image

@june07
Copy link
Owner

june07 commented May 21, 2020

edge: https://microsoftedge.microsoft.com/addons/detail/injfmegnapmoakbmnmnecjabigpdjeme
chrome: https://chrome.google.com/webstore/detail/nodejs-v8-inspector-manag/gnhhdgbaldcilmgcpfddgdbkhjohddkj

So I published the update to both Microsoft and Google. In the event Google in fact takes

several weeks

I would suggest trying Microsoft Edge as I've found things go through the pipeline much faster with them.

@pichuser
Copy link
Author

For those so inclined who would rather not wait I've pushed the file here as well:
https://github.com/june07/NiM/releases/tag/v2.4.0

Thank you so much! Increadible! Perfect!

@june07
Copy link
Owner

june07 commented May 22, 2020

WOW, I take it back!
https://chrome.google.com/webstore/detail/nodejs-v8-inspector-manag/gnhhdgbaldcilmgcpfddgdbkhjohddkj

Kudos @dotproto and team for the swift approval!

@june07 june07 closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants