Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-change theme of extension depending on theme of system #3

Closed
rakleed opened this issue Jun 25, 2023 · 9 comments
Closed

Auto-change theme of extension depending on theme of system #3

rakleed opened this issue Jun 25, 2023 · 9 comments

Comments

@rakleed
Copy link
Contributor

rakleed commented Jun 25, 2023

Could you please add an auto-change of the theme of the extension depending on the theme of the system? More: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme and https://stackoverflow.com/q/56393880/11336855

@june07
Copy link
Owner

june07 commented Jun 25, 2023

533208b

image

@june07
Copy link
Owner

june07 commented Jun 29, 2023

Both Edge and Chrome updates should now be available in their respective places... or https://june07.com/nim.

@june07 june07 closed this as completed Jun 29, 2023
@rakleed
Copy link
Contributor Author

rakleed commented Jun 30, 2023

@june07 thanks, but there are a couple of problems:

  1. If a dark theme is selected in the system and the default settings in the extension, then when the extension window is opened, a white background appears for a fraction of a second.
  2. Maybe instead of the option "Override System Theme" and the sun/moon icons, it is worth making a menu with a choice of theme in the settings with such options - auto (or system), light, dark? So that all the settings are in one place, and the icons of the sun/moon are confusing.

@june07
Copy link
Owner

june07 commented Jun 30, 2023

Please see https://blog.june07.com/nim-dark-mode-update/

As I'm not seeing the same thing on my end, it would be great to get more information about your setup (OS, Chrome version) and a screen capture showing 1.

On point 2., I do agree that the sun/moon icon should be removed if "Override System Theme" is enabled and will make that fix. It's certainly confusing when the icon serves no purpose other than "glitching" on click when the override is in place. Otherwise, having the theme icon where it is helps for those that want quick access to change the theme without going into settings to do so.

@rakleed
Copy link
Contributor Author

rakleed commented Jul 5, 2023

@june07 chrome://extensions/?id=fbbpbfibkcdehkkkcoileebbgbamjelh says that version 3.2.1 is installed, but 3.1.0 is indicated in the extension window itself. Is it my problem or did you build the extension incorrectly?

Screenshots

screenshot-chrome-extensions-1688561510313

Screenshot 2023-07-05 at 15 53 29

@rakleed
Copy link
Contributor Author

rakleed commented Aug 1, 2023

@june07 ping

@june07
Copy link
Owner

june07 commented Aug 1, 2023

Just pushed another update.

@june07 june07 reopened this Aug 1, 2023
@rakleed
Copy link
Contributor Author

rakleed commented Aug 15, 2023

@june07 do you like the current implementation better when the theme can be changed at any time in the main popup? It seems to me that in the settings, instead of Override System Theme, you could make a select with a choice between System, Light and Dark theme, and remove the moon/sun icon.

@june07
Copy link
Owner

june07 commented Aug 21, 2023

I do. But duly noted and I appreciate your feedback.

@june07 june07 closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants