-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-change theme of extension depending on theme of system #3
Comments
Both Edge and Chrome updates should now be available in their respective places... or https://june07.com/nim. |
@june07 thanks, but there are a couple of problems:
|
Please see https://blog.june07.com/nim-dark-mode-update/ As I'm not seeing the same thing on my end, it would be great to get more information about your setup (OS, Chrome version) and a screen capture showing 1. On point 2., I do agree that the sun/moon icon should be removed if "Override System Theme" is enabled and will make that fix. It's certainly confusing when the icon serves no purpose other than "glitching" on click when the override is in place. Otherwise, having the theme icon where it is helps for those that want quick access to change the theme without going into settings to do so. |
@june07 |
@june07 ping |
Just pushed another update. |
@june07 do you like the current implementation better when the theme can be changed at any time in the main popup? It seems to me that in the settings, instead of Override System Theme, you could make a |
I do. But duly noted and I appreciate your feedback. |
Could you please add an auto-change of the theme of the extension depending on the theme of the system? More: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme and https://stackoverflow.com/q/56393880/11336855
The text was updated successfully, but these errors were encountered: