Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not changing package name SplashActivity.java #95

Closed
strdr4605 opened this issue Nov 22, 2019 · 3 comments
Closed

Not changing package name SplashActivity.java #95

strdr4605 opened this issue Nov 22, 2019 · 3 comments

Comments

@strdr4605
Copy link
Contributor

Beside MainActivity and MainApplication I have SplashActivity
image
When running

react-native-rename "Travel App" -b com.junedomingo.travelapp

the package name is not replaced in SplashActivity.
Probable because of https://github.com/junedomingo/react-native-rename/blob/master/src/config/bundleIdentifiers.js#L19
@strdr4605
Copy link
Contributor Author

Solved in fork https://github.com/strdr4605/react-native-rename

@strdr4605 strdr4605 mentioned this issue Nov 29, 2019
Merged
@wilsolutions
Copy link

There is a significant number of PRs, I'm wondering if the current maintainer still maintain this repo...

@vomchik
Copy link
Collaborator

vomchik commented Jan 15, 2021

Fixed in the last release v2.7.0

@vomchik vomchik closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wilsolutions @vomchik @strdr4605