Panic when killing script since 83b6033 'main.go'

[LangLangBart]

Checklist

• I have read through the manual page (man fzf)
• I have searched through the existing issues
• For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version

0.53.0 (brew)

OS

• Linux
• macOS
• Windows
• Etc.

Shell

• bash
• zsh
• fish

Problem / Steps to reproduce

Since commit 83b6033 (main.go), I noticed a panic when killing a script, where fzf runs.

--- a/main.go
+++ b/main.go
@@ -36,5 +36,5 @@ func printScript(label string, content []byte) {
 
 func exit(code int, err error) {
- if err != nil {
+ if code == fzf.ExitError {
    fmt.Fprintln(os.Stderr, err.Error())
  }

to reproduce

Run this small script in a terminal tab; the $$ is copied to your clipboard (macOS only).

#!/usr/bin/env bash

echo $$ | pbcopy
: | FZF_DEFAULT_OPTS="" fzf

In a second terminal tab, run the following:

kill -15 <copied_pid>

Examine the first terminal tab and notice the panic.

panic: runtime error: invalid memory address or nil pointer dereference                                                            
                                                                       [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xb286143]

            goroutine 1 [running]:
                                  main.exit(0x2, {0x0?, 0x0?})
                                                                github.com/junegunn/fzf/main.go:39 +0x23
                                                                                                        main.main()
                                                                                                                        github.com/junegunn/fzf/main.go:81 +0x198

---

possible solution

Maybe check for nil or have a dedicated message for nil?

if code == fzf.ExitError && err != nil

[junegunn]

Thanks, nice find.