New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why Ruby? #22
Comments
Maybe or maybe not. I haven't really thought about it. |
Well, I don't have +ruby feature in my vim, but all seems to work properly. |
@opennota Unfortunately without Ruby, you don't get parallel installation/update which I think is the biggest merit of vim-plug. vim-plug implements parallel installer in Ruby, and the sequential one in Vimscript. |
@junegunn |
@opennota I see. I noticed that you don't use many plugins, so I guess you don't really need speed. I use around 30~40 plugins, I was always bored when I was updating plugins with Vundle :) |
That, and the fact that you don't really need to update when everything works. |
Well, I think we can all agree that writing this in pure VimScript would probably be a real PITA, so people will just have to have |
Hi, The false assumption here is probably justified because I don't know of any other plugin out there that has optional lang requirement. It's either it requires a language or it's pure viml. Anyway, might I suggest updating the readme so it's more clear that Thanks |
Hi @junegunn . Great plugin, thanks for making it. I only recently started using in the new year. I wasn't too happy about the ruby dependence, so I've been making a parallel python update function. I've now got something working and moved it into an official fork (https://github.com/starcraftman/vim-plug) for tracking purposes. Currently should work on *NIX with just +python, though I've only officially tested on Linux. Would you be interested in eventually pulling this? No PR yet as I need more testing, especially on Mac. Edit: Kinda putting this here as related, alternative to ruby. Though I can make a new issue of course. |
@starcraftman Hi, thanks for taking the initiative. I know that +python is generally more popular than +ruby, so I think it makes sense to have that version of installer. There are of courses some concerns.
When you're ready please send me a PR, we'll continue the discussion there. Thanks! |
@starcraftman I work only on mac at the moment so I'll be glad to test it ;) |
@junegunn Some responses to concerns you raised.
I agree, adds more complexity. I might recommend an object oriented VimL refactor (after the python PR?) that would reduce our number of if blocks. If done correctly, could make a standard interface for the n number methods we install with. See at the end of my . Just a simple example if you haven't seen the style. I don't mind maintaining all the python, one of my favorite languages.
I haven't noticed any, I'm pretty sure plugins cause most of the delay. We can check when PR made, I'm doubtful or I'd have felt it.
No problem. I shall try and pitch in when I can, know VimL quite well and should read up on nvim jobs. Ruby not as much.
+python means python2 only to be clear and +python3 means python 3 only block. The versions required I believe just rely on what libraries used I believe. In my code, I've used stuff that was added around 2.6 so any 2 version after that should work. I don't think there's as many +python3 vim users so I wouldn't put that at top of my list, but support shouldn't be hard.
I will look into this. I don't have experience with Travis, so I'll read up. I'm used to just running my tests locally. I'll keep this stuff in mind while working on my fork. |
These changes can't affect the load time by much. At startup vim loads the vimrc which then call the |
@starcraftman @vheon Agreed. I don't think the added overhead will be greater than a millisecond. I just wanted to share every idea and concern that popped inside my head. The reason I mentioned python version compatibility is that for +ruby, the version can vary greatly. It can be 1.8 or it can be 2.2. So I had to make sure that I was not using any newer syntax introduced after 1.8. So I presumed that you might have to take similar care when writing it in python. Regarding the refactoring, in this case, the number of if blocks is not a problem but the number of implementations is. So I don't think changing the style would help much. I'll look forward to your PR, thanks! |
@starcraftman @vheon |
@junegunn I await the inevitable, "Why not Perl?" :P |
Can't you do this in plain VIML? Maybe with https://github.com/tpope/vim-dispatch?
The text was updated successfully, but these errors were encountered: