Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why center crop for testing instead of the whole image? #44

Closed
zimenglan-sysu-512 opened this issue Mar 26, 2019 · 7 comments
Closed

why center crop for testing instead of the whole image? #44

zimenglan-sysu-512 opened this issue Mar 26, 2019 · 7 comments

Comments

@zimenglan-sysu-512
Copy link

hi @junfu1115
i have a question: in BaseDataset, the func _val_sync_transform use center-crop to crop the image. is it reasonable to use center-crop to test the model instead of the whole image?
thanks.

@junfu1115
Copy link
Owner

@zimenglan-sysu-512 you can ref zhanghang1989/PyTorch-Encoding#127 (comment) and we adopt test.py to obtain final result

@zimenglan-sysu-512
Copy link
Author

hi @junfu1115
in danet/test.py, it seems that u don't set any params for base_size and crop_size, and still use _val_sync_transform to process the image.
can u show some details how do u process the image and mask when u test?

@zihao-lu
Copy link

@zhiweifang he uses the whole image without sync_transform when testing

@zimenglan-sysu-512
Copy link
Author

hi @Mr-zihao
can u show me the code? i can't find them. thanks.

@zihao-lu
Copy link

@zimenglan-sysu-512 in test.py, the mode of get_dataset_model is testval with which the images only are transformed into tensor without crop、flip etc...

@zihao-lu
Copy link

@zimenglan-sysu-512 And if you get the same result as the paper,please tell me,thanks,there are some troubles with me.

@zimenglan-sysu-512
Copy link
Author

zimenglan-sysu-512 commented Mar 26, 2019

@Mr-zihao
u are right, i ignore this detail. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants