Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin refactor RFC #36

Open
6 tasks
juniorxsound opened this issue Dec 9, 2022 · 4 comments
Open
6 tasks

Plugin refactor RFC #36

juniorxsound opened this issue Dec 9, 2022 · 4 comments

Comments

@juniorxsound
Copy link
Owner

It's been a moment since this plugin was last maintained and quite a lot has changed so wanted to collect some thoughts on potential future improvements.

  • New build system (perhaps Vite) to produce an ES module and externalizing three.js
  • Typescript
  • Build plugin in Github action on commit to avoid having to checkin built plugin file (i.e ./build/depthkit.js)
  • Deploy npm package via Github action on tag
  • Add support for new Depthkit metadata structure (i.e Combined-Per-Pixel video is not compatibility!! #24)
  • Better examples for WebXR API usage
@remmel
Copy link

remmel commented Jan 4, 2023

I can migrate the code to es6 / esm (A build system won't be needed in that case). However I can also add a webpack build system to create an UMD build (w/o THREE) for thoses who don't want to use esm from browser (the only usage I see is, when using aframe lib direcly without aframe-dephkit component ; note that es6 as es-module-shims make esm available ~everywhere)

@ROBYER1
Copy link

ROBYER1 commented Jan 5, 2023

npm package + Typescript + Vite plugin system as an ES module would be essential for my work projects using Needle Tools and other things using Vite.

Support for newer depthkit metadata structure is also essential for use of up to date versions. Thanks for your work on this!

@remmel
Copy link

remmel commented Jan 5, 2023

@ROBYER1 Why do you need depthkit to use typescript and vite? Your project should not be dependent on the build system of the library it uses. For example you are using THREE which is built with esm and rollup

@ROBYER1
Copy link

ROBYER1 commented Jan 17, 2023

@ROBYER1 Why do you need depthkit to use typescript and vite? Your project should not be dependent on the build system of the library it uses. For example you are using THREE which is built with esm and rollup

Makes sense to me, I'm still figuring out a lot of Vite but thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants