Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release script hardcodes remote name #2

Closed
dceara opened this issue Jun 14, 2016 · 0 comments
Closed

Release script hardcodes remote name #2

dceara opened this issue Jun 14, 2016 · 0 comments
Assignees
@dceara
Labels
bug
Milestone
1.1

Comments

@dceara
Copy link
Collaborator

dceara commented Jun 14, 2016

The "origin" remote name is hardcoded in the release.sh script. This might not always be correct.

Also, the check which prevents running the script on a non-master branch is commented out.
@dceara dceara added the bug label Jun 14, 2016
@dceara dceara added this to the 1.1 milestone Jun 14, 2016
@dceara dceara self-assigned this Jun 14, 2016
dceara pushed a commit to dceara/warp17 that referenced this issue Jun 14, 2016
Add <remote-name> argument to release.sh
cc80780 
Issue: Juniper#2

Also uncomment the check that prevents running the script on non-master
branches.
@dceara dceara mentioned this issue Jun 14, 2016
Merged
@dceara dceara closed this as completed Jun 15, 2016
@jlijian3 jlijian3 mentioned this issue Oct 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dceara dceara

Labels
bug
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@dceara