-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a @FailAt annotation #549
Comments
What's the upside of the annotation over this one-liner: assumeTrue(LocalDate.now().isBefore(2022,1,1), "An optional reason"); // or assertTrue if you want the test to fail, not abort |
Hm, I guess, you could say that this assumption/assertion is meta - it's not really an assertion or assumption that is part of the test and therefore should be moved out from the method body? 🤔 |
@Michael1993 Exactly, IMHO it should be separate from the actual assertions. An annotation would also give you a visual clue that this is something you need to be aware of, and makes searching for the existence of such tests simpler (e.g. by grepping for the annotation). But maybe the annotation is too esoteric to be included in JUnit Pioneer 😄 . |
Not at all! Our |
Hi @Michael1993, I can take a stab at it 🙂! |
Hm I see this is the same as edit: @Michael1993 explained me the difference. |
We talked about this at our last team meeting and want you to invite to take part in a discussion to think about this and similar use cases in a more global view. Feel free to write down your thoughts and ideas in #550 - thank you! |
Ooops, not so much of a duplicate after all. 😊 Still, let's first discuss in #550. |
Inspired by https://twitter.com/mikeveerman/status/1464162014444638258
It would be nice to provide an annotation that fails at a specified date, with on optional reason. Something like this:
This could be a great way to remind oneself of unpaid technical debt but could probably also be used in other contexts.
The text was updated successfully, but these errors were encountered: