Confusing error with ParameterSupplier

[leeavital]

I hit this error message when:

https://github.com/junit-team/junit.contrib/blob/master/theories/src/main/java/org/junit/contrib/theories/Theories.java#L88

• my supplier class had default visibility instead of public
• my supplier class had a declared no-args constructor

Would it make sense to change the message to "Supplier class X must not declare a constructor and must be public" ?

[marcphilipp]

@pholser Can you take a look, please?

[pholser]

@leeavital What about changing the message to:

Supplier class X needs a single public constructor

If your class is marked public but declares no ctors, then X.class.getConstructors() gives a one-element array; this element is the free public zero-arg ctor you get when you declare no constructors.

[leeavital]

I'm pretty sure I got this error even when I had a single no-args constructor declared. I don't have a good reproduction at the moment though