This is a fix for #83 support @Rule on methods #325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend rules to support @rule public MethodRule someRule() { return new SomeRule(); }
Scala does not allow the creation of public fields. If you declare a field public, the field is created as private but with accessor methods.
To allow the use of @rule with Scala fields, this patch allows the addition
of @rule to methods. When BlockJUnit4ClassRunner retrieves the list of fields
that have the @rule annotation, it also searches for methods with @rule.
These methods are called and the values returned are added to the list of
TestRule.
@ClassRule has been similarly changed.
This is intended to be used as follows:
private ExpectedException thrown = rules.ExpectedException.none();
@rule public ExpectedException getThrown() {
return thrown;
}
or
@rule public Timeout getTimeout() {
return new Timeout(20);
}
The validation is exactly the same as for the fields, i.e the methods must be
public and return a TestRule/MethodRule. In the case of @ClassRule, the
methods must also be static.