Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #426 new consistent coding style #492

Closed
wants to merge 1 commit into from

Conversation

awulder
Copy link

@awulder awulder commented Aug 22, 2012

Reformatted the code base for an consistent coding/formatting style

Reformatted the code base for an consistent coding/formatting style
@dsaff
Copy link
Member

dsaff commented Sep 4, 2012

Arjan,

Sorry for the delay in getting to this. Can you find a set of formatting rules that do not create such sweeping changes to long-standing classes like junit.framework.Assert?

@awulder
Copy link
Author

awulder commented Sep 7, 2012

David,

Do you have suggestions? I don't think the changes in junit.framework.Assert are that sweeping. Uses spaces instead of tab character, the use of curly brackets, space before and after the equal sign and some blank lines.

@dsaff
Copy link
Member

dsaff commented Sep 7, 2012

Okay, let's do this in two steps:

Pull 1: create some kind of README file that states the new coding style.
Pull 2: actually commit it.

I agree, on second review, that the changes are none too violent, but I'd like something I can point people to and say: "Please make your code follow these rules." Sounds good?

Sorry for the initial trepidation.

@awulder
Copy link
Author

awulder commented Sep 7, 2012

I agree. I will first create a coding style document.

@dsaff
Copy link
Member

dsaff commented Oct 4, 2012

I apologize: now that the style guide is in, it looks like you'll need to re-apply the style changes. I hope that's not too hard.

@dsaff
Copy link
Member

dsaff commented Nov 5, 2012

We can close this, right?

@marcphilipp
Copy link
Member

I think so, because #522 has been merged. The corresponding issue (#426) is still open, though, because the Eclipse formatter settings are still missing.

@dsaff dsaff closed this Nov 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants